Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free after value resolution #335

Merged
merged 2 commits into from Jun 24, 2022
Merged

free after value resolution #335

merged 2 commits into from Jun 24, 2022

Conversation

mbostock
Copy link
Member

Fixes #334. Rather than setting the variable._observer to true (and never restoring the original no_observer), create a new variable that takes the named variable as input, and observe that. That way we can delete the variable when we’re done.

@mbostock mbostock requested review from duaneatat and annie June 22, 2022 18:05
@mbostock mbostock merged commit 2f8024a into main Jun 24, 2022
@mbostock mbostock deleted the mbostock/value-cleanup branch June 24, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module.value should stop observing after the value resolves
2 participants